Filter for tx receipts with any obscuro interactions #1509
Merged
+50
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BedrockSquirrel
force-pushed
the
matt/fix-receipt-filtering
branch
from
0e8389e to
ef5e75d
Compare
BedrockSquirrel
commented
Sep 12, 2023
| if !g.submitDataLock.TryLock() { | ||
| g.logger.Info("Unable to submit block, already submitting another block") | ||
| // we are already submitting a block, and we don't want to leak goroutines, we wil catch up with the block later | ||
| return false, nil | ||
| } | ||
| receipts, err := g.sl.L1Repo().FetchObscuroReceipts(block) |
There was a problem hiding this comment.
I moved this after the TryLock because we sometimes end up duplicating the effort otherwise.
StefanIliev545
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Currently we only send tx receipts to the enclave for L1 transactions addressed
toan obscuro contract (message bus or management contract).However we need to capture receipts for any transaction that interacts with those contracts even if the transaction is not addressed
tothe contract directly.This was breaking local network and testnet networks deployments because the whitelist ERC20 bridge script was failing.
What changes were made as part of this PR
Make an
eth_getLogscall to fetch all logs in the block and scan through them to see if they come from the obscuro relevant contracts.Send receipts for those transactions.
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks